Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/628/rad min max in ensemble #631

Merged
merged 18 commits into from
Aug 5, 2024
Merged

Issue/628/rad min max in ensemble #631

merged 18 commits into from
Aug 5, 2024

Conversation

m-aguena
Copy link
Collaborator

Solves Issue #628

@hsinfan1996 hsinfan1996 linked an issue Jul 16, 2024 that may be closed by this pull request
Check how (or if) radial bin edges are propagated to the cluster ensemble profile #628
Closed
@m-aguena m-aguena marked this pull request as ready for review July 17, 2024 13:25
@coveralls
Copy link

coveralls commented Jul 17, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 32965de on issue/628/rad_min_max_in_ensemble
into 2d5aa5b on main.

marina-ricci
marina-ricci requested changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@marina-ricci marina-ricci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-aguena Looks good to me, thank you! The only thing is that I prefer to rename "ops.py" to "dataops.py" or even "data_operations.py", because I find it confusing to have another name.

@marina-ricci
Copy link
Collaborator

Also, you might want to merge after Caio's PR, as it would be easier for you to resolve the merge conflicts.

@hsinfan1996
Copy link
Collaborator

hsinfan1996 commented Jul 18, 2024 •
edited
Loading

NumCosmo deprecated new_from_name, so we need to update the notebook demo_mock_ensemble_realistic.ipynb (in a separate PR maybe). I fixed it.

@hsinfan1996
Copy link
Collaborator

Just out of curiosity, I would like to know reason behind writing a new class DiffArray. Is it there for making the arrays in the table work with update_info_ext_valid?

@m-aguena
Copy link
Collaborator Author

Just out of curiosity, I would like to know reason behind writing a new class DiffArray. Is it there for making the arrays in the table work with update_info_ext_valid?

Good eye! That is the exact reason

@m-aguena m-aguena merged commit 0f26571 into main Aug 5, 2024
2 checks passed
m-aguena added a commit that referenced this pull request Aug 5, 2024
@m-aguena @hsinfan1996
Issue/628/rad min max in ensemble (#631)
e95f0e0 
* add radius min/max in ensamble and validation for its consistency

* pass rmin/max to ClusterEnsemble.stacked_data

* Update version to 1.13.0

---------

Co-authored-by: Hsin Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsinfan1996 hsinfan1996 hsinfan1996 approved these changes

@marina-ricci marina-ricci marina-ricci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check how (or if) radial bin edges are propagated to the cluster ensemble profile
4 participants
@m-aguena @coveralls @marina-ricci @hsinfan1996